Skip to content

feat: declare group mentions and mentions of everyone, and pass the kind of a mention - #31

Merged
alexmorbo merged 1 commit into
masterfrom
s-142-group-mentions
Nov 17, 2026
Merged

alexmorbo merged 1 commit into
masterfrom
s-142-group-mentions

Conversation

@alexmorbo

Copy link
Copy Markdown
Contributor

Part of muster-io/muster#431

Story: S-142

Acceptance

Statement Evidence
api/bridge.yaml is Muster's copy byte for byte; generate-check current with Capabilities.group_mentions, Capabilities.everyone_mentions, Mention.kind; a Mention without kind reads as user make spec-check generate-check pass in make ci; tests/test_mentions.py::test_a_mention_without_kind_is_a_user
Configuration takes group_mentions and everyone_mentions, info declares them; a repeated name raises ConfigError, a name outside the four is refused tests/test_config.py: "duplicate everyone mention", "unknown everyone mention", "group_mentions not a boolean", test_group_and_everyone_mentions_are_declared_in_info; test_spec.py::test_info_with_every_member_matches_the_specification
replace_mentions hands each entry with its kind; group/everyone entries carry the name; an entry of an undeclared kind is never refused and shows as the marker's link text tests/test_mentions.py::test_render_gets_each_entry_with_its_kind, ::test_an_undeclared_kind_is_shown_as_the_link_text_of_its_marker; tests/test_app.py::test_the_messenger_gets_the_kind_of_each_mention, ::test_a_bridge_without_group_or_everyone_mentions_never_refuses_their_entries; tests/test_spec.py "201 mentions of every kind"
README example (group mentions and here; renders a user, a group and here) is run by tests tests/test_mentions.py::test_the_readme_example_renders_a_user_a_group_and_here
make ci conformance passes make ci: 417 passed, 100% coverage, spec copy current; make conformance on Linux (muster-lab) with ghcr.io/muster-io/muster:edge: memory-all, memory-thread-messages, memory-interactive passed

Verify

make ci: lint, mypy strict, generate-check, spec-check, licenses, 417 tests at 100% coverage, build: all passed. make conformance (Linux VM): all three runs passed.

Changes

  • Config holds capabilities: Capabilities, so the story's Config.group_mentions / Config.everyone_mentions are Capabilities.group_mentions / Capabilities.everyone_mentions. The story's Notes should say so.
  • replace_mentions's render may return None, which gives the marker's link text (no declared-capability knowledge in the function). Existing callers are unaffected.
  • examples/memory_bridge.py gains the features group_mentions and everyone_mentions (not in files_touched; the story's Verification needs them).
  • A kind beyond the three of the specification is still answered invalid by the closed generated models, as the specification says.

No dependencies added. Maintainer: merges the release-please PR for the next 0.x release.

@alexmorbo alexmorbo closed this Nov 17, 2026
@alexmorbo alexmorbo reopened this Nov 17, 2026
@alexmorbo
alexmorbo merged commit 91fe6bb into master Nov 17, 2026
27 of 29 checks passed
@alexmorbo
alexmorbo deleted the s-142-group-mentions branch November 17, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant