Repository navigation
feat: declare group mentions and mentions of everyone, and pass the kind of a mention - #31
Merged
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of muster-io/muster#431
Story: S-142
Acceptance
api/bridge.yamlis Muster's copy byte for byte;generate-checkcurrent withCapabilities.group_mentions,Capabilities.everyone_mentions,Mention.kind; a Mention withoutkindreads asusermake spec-check generate-checkpass inmake ci;tests/test_mentions.py::test_a_mention_without_kind_is_a_usergroup_mentionsandeveryone_mentions,infodeclares them; a repeated name raisesConfigError, a name outside the four is refusedtests/test_config.py: "duplicate everyone mention", "unknown everyone mention", "group_mentions not a boolean",test_group_and_everyone_mentions_are_declared_in_info;test_spec.py::test_info_with_every_member_matches_the_specificationreplace_mentionshands each entry with its kind; group/everyone entries carry the name; an entry of an undeclared kind is never refused and shows as the marker's link texttests/test_mentions.py::test_render_gets_each_entry_with_its_kind,::test_an_undeclared_kind_is_shown_as_the_link_text_of_its_marker;tests/test_app.py::test_the_messenger_gets_the_kind_of_each_mention,::test_a_bridge_without_group_or_everyone_mentions_never_refuses_their_entries;tests/test_spec.py"201 mentions of every kind"here; renders a user, a group andhere) is run by teststests/test_mentions.py::test_the_readme_example_renders_a_user_a_group_and_heremake ci conformancepassesmake ci: 417 passed, 100% coverage, spec copy current;make conformanceon Linux (muster-lab) withghcr.io/muster-io/muster:edge: memory-all, memory-thread-messages, memory-interactive passedVerify
make ci: lint, mypy strict, generate-check, spec-check, licenses, 417 tests at 100% coverage, build: all passed.make conformance(Linux VM): all three runs passed.Changes
Configholdscapabilities: Capabilities, so the story'sConfig.group_mentions/Config.everyone_mentionsareCapabilities.group_mentions/Capabilities.everyone_mentions. The story's Notes should say so.replace_mentions'srendermay returnNone, which gives the marker's link text (no declared-capability knowledge in the function). Existing callers are unaffected.examples/memory_bridge.pygains the featuresgroup_mentionsandeveryone_mentions(not infiles_touched; the story's Verification needs them).kindbeyond the three of the specification is still answeredinvalidby the closed generated models, as the specification says.No dependencies added. Maintainer: merges the release-please PR for the next 0.x release.